Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct language for --rest-api-host-allowlist #610

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

joaniefromtheblock
Copy link
Contributor

Fixes #599

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-teku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 8:39pm

@joaniefromtheblock
Copy link
Contributor Author

@rolfyone Please review

@joaniefromtheblock joaniefromtheblock self-assigned this Oct 4, 2024
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of little things but close :)

A comma-separated list of hostnames or IP addresses from which the REST API server will respond.
This flag restricts the server's responding addresses, but not the client access.

You can listen on all addresses using `--rest-api-interface="*"` but restrict responses to specific hosts with this flag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface is 0.0.0.0

Comment on lines +2782 to +2783
When you configure the interface to listen on all available IP addresses (`rest-api-interface: "0.0.0.0"`) and allow all hosts
(`["*"]`), you enable connections from any address, such as `localhost` (127.0.0.1) or a specific network IP such as `10.0.0.1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow all hosts (rest-api-host-allowlist)
I believe the ["*"] is specific to configuration file syntax for allowlist...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--rest-api-host-allowlist description discrepancy
2 participants